add deployment checks #404
Conversation
.circleci/config.yml
Outdated
| @@ -67,6 +96,7 @@ workflows: | |||
| build-test: | |||
| jobs: | |||
| - runtest | |||
| - deployment-checks | |||
There was a problem hiding this comment.
I didn't add a filter for this yet. The job runs pretty fast right now, so my thinking was to leave it on all commits until we have the need to limit it if stuff is slow. Not a strong preference, though.
There was a problem hiding this comment.
update: they do take long. I'm adding the filter here as well.
fastlane/Fastfile
Outdated
| check_pods | ||
| carthage_archive | ||
| check_no_github_release_exists |
There was a problem hiding this comment.
Couldn't think of other stuff to check that wouldn't be covered by integration tests, but I think this would be pretty helpful to have
|
|
||
| def carthage_archive | ||
| # can't use fastlane carthage integration directly because of Carthage/Xcode 12 compatibility issues: | ||
| # https://github.com/Carthage/Carthage/issues/3019 |
There was a problem hiding this comment.
This makes me so sad everytime I see it. I hope they fix it soon haha
aboedo
force-pushed
the
feature/deployment_checks
branch
2 times, most recently
from
06777b8
to
a925b03
Compare
…ep to deployment checls
…on number doesn't already exist.
aboedo
force-pushed
the
feature/deployment_checks
branch
from
3a1fa55
to
c9a4bb7
Compare
|
@vegaro I made a couple of updates:
|
| xcode: "12.0" | ||
| xcode: "12.2.0" |
There was a problem hiding this comment.
both pod lib lint and the carthage integration step were failing on 12.0. I'm really not sure what was going on, though - 12.0 does compile locally and deployment_checks pass locally on 12.0 on my computer.
It would not find SKPaymentQueue's presentCodeRedemptionSheet, which is weird because it was added on 12.0.
Really not sure what was going on there, but this should at least fix the tests for the time being.
If we want to be compatible with Xcode 11, though, we could add a compiler flag similar to the one in ErrorUtils.
adds deployment checks to ensure that the framework can be published successfully.
it checks:
Together with integration tests, this should give us pretty solid coverage over things that can go wrong when deploying.