Storekittest headers #407
Merged
Storekittest headers #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aboedo
commented
Nov 30, 2020
Purchases/Networking/RCHTTPClient.m
Outdated
| @"X-Client-Build-Version": RCSystemInfo.buildVersion, | ||
| @"X-Observer-Mode-Enabled": observerMode, | ||
| #if UI_DEVICE_AVAILABLE | ||
| @"X-Apple-Device-Identifier": UIDevice.currentDevice.identifierForVendor.UUIDString, |
There was a problem hiding this comment.
this doesn't work for Mac, on Mac we need to send the guid (see PR description)
aboedo
commented
Dec 1, 2020
Comment on lines
+74
to
+80
| #if UI_DEVICE_AVAILABLE | ||
| return UIDevice.currentDevice.identifierForVendor.UUIDString; | ||
| #elif WKINTERFACE_DEVICE_AVAILABLE | ||
| return WKInterfaceDevice.currentDevice.identifierForVendor.UUIDString; | ||
| #endif | ||
| return nil; |
There was a problem hiding this comment.
this should be compatible with watchOS, tvOS, and Catalyst (so everything but native mac)
There was a problem hiding this comment.
I'm not 100% sure about Catalyst, though, since I'm not sure whether it uses the idfv or guid for signing. I'll add support for all Mac on a separate PR, though.
There was a problem hiding this comment.
this code somewhat duplicates what we have on RCAttributionFetcher, but the cleanup will also come on a different PR for the sake of shipping
aboedo
force-pushed
the
storekittest_headers
branch
from
17341ee
to
087a040
Compare
… auto-determined by the backend
aboedo
force-pushed
the
storekittest_headers
branch
from
7f8b87e
to
4e8dbd4
Compare
MiguelCarranza
approved these changes
Dec 1, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the headers needed for receipts made using StoreKitTest to validate correctly.
Remaining work:
Note: the current version is only compatible with iOS.
For MacOS compatibility (v2):
on Mac, instead of the idfv, we need to send the guid https://developer.apple.com/library/archive/releasenotes/General/ValidateAppStoreReceipt/Chapters/ValidateLocally.html#//apple_ref/doc/uid/TP40010573-CH1-SW14