Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip offerings backend call with error if appUserID is empty #414

Merged
merged 1 commit into from Dec 17, 2020

Conversation

aboedo
Copy link
Member

@aboedo aboedo commented Dec 4, 2020

We're getting a few calls to the backend for offerings on empty appUserID strings.
This checks whether the appUserID is empty before posting to the backend, and early exists with an error if that's the case.

@aboedo aboedo requested a review from vegaro December 4, 2020 19:48
@aboedo aboedo self-assigned this Dec 4, 2020
@aboedo aboedo modified the milestones: 3.9.1, 3.9.2 Dec 4, 2020
@aboedo aboedo merged commit 1f69adc into develop Dec 17, 2020
@aboedo aboedo deleted the fix/skip_get_offerings_if_appuserid_empty branch December 17, 2020 13:50
@aboedo aboedo mentioned this pull request Dec 17, 2020
@aboedo aboedo mentioned this pull request Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants