Logging v2 part 1 strings #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiinanguyen
commented
Dec 18, 2020
This was referenced Dec 18, 2020
aboedo
reviewed
Dec 18, 2020
aboedo
reviewed
Dec 18, 2020
aboedo
reviewed
Dec 22, 2020
| RCLog(@"called post subscriber attributes with an empty attributes dict!"); | ||
| RCWarnLog(@"%@", RCStrings.attribution.empty_subscriber_attributes); |
There was a problem hiding this comment.
why do some of these do (@"%@", <string>); while others just pass it in directly?
There was a problem hiding this comment.
@aboedo The (@"%@", <string>); is to treat it as a string literal or else Xcode throws warnings. Others pass in directly have a string formatter and Xcode doesn't complain.
aboedo
approved these changes
Dec 23, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR currently adds the following string files:
AttributionStrings,ConfigureStrings, andPurchaserInfoStrings.Part 2: #428
Part 3: #430
Additional log methods: #422