identity v3: public-facing changes #453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aboedo
force-pushed
the
feature/identityV3
branch
from
35de297
to
c662650
Compare
aboedo
force-pushed
the
feature/identityV3_public_facing_changes
branch
from
c741906
to
c0e4657
Compare
vegaro
approved these changes
Jan 21, 2021
Purchases/Public/RCPurchases.h
Outdated
| NS_SWIFT_NAME(reset(_:)) __attribute((deprecated("Use logOut instead."))); | ||
|
|
||
| /** | ||
| This function will identify the current user with an appUserID. |
|
Hi, When is this functionality being finalised ? We're working our backend against the alias functionality and I would like to know if we'll have to change once this login / logout functionality is finalised |
@mmdumi We're targeting end of February but that may get pushed out. All of these changes will be backwards compatible with the current functionality so you won't have to make any changes 👍 |
aboedo
force-pushed
the
feature/identityV3_public_facing_changes
branch
2 times, most recently
from
397598c
to
cc21683
Compare
aboedo
force-pushed
the
feature/identityV3
branch
from
d34e785
to
c3a6f58
Compare
aboedo
force-pushed
the
feature/identityV3_public_facing_changes
branch
from
cc21683
to
9432eae
Compare
aboedo
force-pushed
the
feature/identityV3
branch
from
c3a6f58
to
c6d18fa
Compare
aboedo
force-pushed
the
feature/identityV3_public_facing_changes
branch
from
9432eae
to
8f01e91
Compare
aboedo
force-pushed
the
feature/identityV3
branch
from
45c9647
to
547efd2
Compare
aboedo
force-pushed
the
feature/identityV3_public_facing_changes
branch
from
8f01e91
to
b0d7375
Compare
aboedo
force-pushed
the
feature/identityV3
branch
from
1196b7c
to
404edf4
Compare
aboedo
force-pushed
the
feature/identityV3_public_facing_changes
branch
from
b0d7375
to
160a86a
Compare
aboedo
force-pushed
the
feature/identityV3_public_facing_changes
branch
5 times, most recently
from
dcd1a62
to
c353b89
Compare
aboedo
force-pushed
the
feature/identityV3_public_facing_changes
branch
from
c353b89
to
2a9370c
Compare
aboedo
force-pushed
the
feature/identityV3_public_facing_changes
branch
2 times, most recently
from
8def2e2
to
920fb49
Compare
aboedo
force-pushed
the
feature/identityV3_public_facing_changes
branch
from
920fb49
to
d3ba3ff
Compare
aboedo
force-pushed
the
feature/identityV3_public_facing_changes
branch
from
e4db6f6
to
61c0671
Compare
aboedo
force-pushed
the
feature/identityV3_public_facing_changes
branch
from
61c0671
to
be41eb2
Compare
Closed
beylmk
reviewed
May 28, 2021
Purchases.podspec
Outdated
| @@ -22,7 +22,7 @@ Pod::Spec.new do |s| | |||
| s.tvos.deployment_target = '9.0' | |||
|
|
|||
| s.pod_target_xcconfig = { 'DEFINES_MODULE' => 'YES' } | |||
| s.dependency 'PurchasesCoreSwift', '3.12.0-SNAPSHOT' | |||
| s.dependency 'PurchasesCoreSwift' | |||
There was a problem hiding this comment.
is this for local development? we'll need to add a version right?
aboedo
force-pushed
the
feature/identityV3_public_facing_changes
branch
from
be41eb2
to
8370c47
Compare
Merged
aboedo
added a commit
that referenced
this pull request
Jul 21, 2021
* Create CODE_OF_CONDUCT.md (#589) Resolves #588 * Update issue templates (#537) * Update issue templates Looks like GitHub wants this named differently 🤷♂️ * Delete migration_task.md * Update custom.md * Update README.md (#636) Just removing the outdated image on the readme * ETags support (#509) * identity v3: public-facing changes (#453) * re-added the public-facing changes for identity v3 * updated nullability for errors in login * temporarily removed version from PurchasesCoreSwift in Purchases.podspec * updated sample app to use identity v3 * improved copy in RCPurchases.h * Integration tests: Identity v3 test cases (#506) * added extra test case for storekit tests * added more test cases * added a few more test cases * slight cleanup * added another, particularly gnarly test case * updated test case name * added another test case * one more test case * refactors and cleanups, made chained calls more reliable for one test case * fixed name, added debug information to appUserIDs * fixed issue with test clearing transactions when it shouldn't * formatting * code cleanup * update call to replace api key and proxy url to catch issues if proxy url is empty * updated syntax since lanes are executed in a block * updated xcode and simulator versions for storekitTests * updated syntax for setting log levels * fixed fastlane changes that broke replace_in for storekit_tests * update fastlane * improvements from PR comments * restricted storekit_tests to release tags and branches * removed signing for storekittest app since it only runs in simulator * removed storekitTestCertificate.cer since it's not needed, re-added tests just in case * restricted storekit_tests to release branches and tags again now that they passed * Bump addressable in /IntegrationTests/CocoapodsIntegration (#647) Bumps [addressable](https://github.com/sporkmonger/addressable) from 2.7.0 to 2.8.0. - [Release notes](https://github.com/sporkmonger/addressable/releases) - [Changelog](https://github.com/sporkmonger/addressable/blob/main/CHANGELOG.md) - [Commits](sporkmonger/addressable@addressable-2.7.0...addressable-2.8.0) --- updated-dependencies: - dependency-name: addressable dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * remove unused typedef to fix build warning (#649) * Release: 3.12.0 (#648) * looks like in some rebase createAlias got un-deprecated, re-deprecated it * updated changelog and version number to 3.12.0 * added missing PR for identity v3 in changelog * added install swiflint step to more ci jobs * fix typo in circleci config.yml * updated the name of the swiftlint step in xcode so it's more obvious at first glance when it fails * fixed an issue where a few targets wouldn't compile correctly when doing carthage archive because they were pointing to unreleased versions of Purchases. * re-added the old carthage script for archives * added `vendor` folder to excluded directories for swiftlint * Preparing for next version (#656) Co-authored-by: Andy Boedo <andresboedo@gmail.com> * added swiftlint installation to all places that were missing it (#657) * Release: 3.12.1 (#659) * renamed eTagInResponse -> maybeEtagInResponse to resolve conflict in some versions of Xcode * updated version number to 3.12.1 and changelog * added `scan_derived_data` to excluded directories for swiftlint * Preparing for next version (#661) Co-authored-by: Distiller <distiller@static.38.39.178.68.cyberlynk.net> * Fix: Calling `setDebugLogsEnabled(false)` enables debug logs when it should not (#663) * fixed a bug where setting debugLogsEnabled = false would still set them to true * cleanup: replaced if / else with ternary operator * reverted changes in SystemInfo initialization * format fixes * removed rchttpRequest * updated call in `buildTvWatchAndMacOS`: install-gems -> install-dependencies * undo accidental whitespace * deleted empty RCSystemInfo.m file Co-authored-by: Joshua Liebowitz <taquitos@users.noreply.github.com> Co-authored-by: Corey Rabazinski <6013553+CoreyRab@users.noreply.github.com> Co-authored-by: Cesar de la Vega <cesarvegaro@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: revenuecat-ops <60164957+revenuecat-ops@users.noreply.github.com> Co-authored-by: Distiller <distiller@static.38.39.178.68.cyberlynk.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #438
This adds only the public-facing changes, so that we can integrate the main identity v3 PR without worrying about making changes available publicly through the SDK until we're ready.
Public changes overview
New methods
logIn, a new way of identifying users, which also returns whether a new user has been registered in the system.logInuses a new backend endpoint.logOut, a replacement forreset.Deprecations / removals
createAliasidentifyin favor oflogInresetin favor oflogOutallowSharingAppStoreAccountin favor of dashboard-side configuration