Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ETags support #509

Merged
merged 44 commits into from Jul 9, 2021
Merged

ETags support #509

Show file tree
Hide file tree
Changes from 43 commits
Commits
Show all changes
44 commits
Select commit Hold shift + click to select a range
44ca7cf
amend
vegaro May 19, 2021
ada4b7c
tests wrap up
vegaro May 21, 2021
d523a3d
changes to nsuserdefaults
vegaro May 21, 2021
bd2b387
adds test with retries
vegaro May 22, 2021
cffb3b0
adds xcsheme changes
vegaro May 22, 2021
5d10c02
Merge branch 'develop' into etags-support
vegaro May 26, 2021
5ce9859
remove explicit type from bundleidentifier
vegaro Jun 11, 2021
d3c734c
removes testing leftovers
vegaro Jun 11, 2021
96cb61e
removes check for data.length
vegaro Jun 11, 2021
6c59c7a
removes unneeded space after cast
vegaro Jun 11, 2021
99b32b3
makes userdefaults immutable
vegaro Jun 11, 2021
1fbd251
renames to eTagHeader
vegaro Jun 11, 2021
3fe986c
extracts ETagAndResponseWrapper
vegaro Jun 11, 2021
e8f33ab
converts class to struct
vegaro Jun 11, 2021
b4817da
changes generics with []
vegaro Jun 11, 2021
48c9622
uses fatalerror instead of as!
vegaro Jun 11, 2021
dcf41b0
removes unnecessary parenthesis and more [:]
vegaro Jun 11, 2021
7cafe57
suggested changes to etagmanager
vegaro Jun 14, 2021
0c5004a
Merge branch 'main' into etags-support
vegaro Jun 16, 2021
d309be9
fixes linter errors
vegaro Jun 17, 2021
6cb354e
updates mocketagmanager
vegaro Jun 17, 2021
7b66bb8
removes force unwrap from responseobject
vegaro Jun 25, 2021
10dd69a
removes retry block
vegaro Jun 25, 2021
a5beb47
rename responseObject to jsonObject
vegaro Jun 25, 2021
92772f9
make static properties private
vegaro Jun 25, 2021
937708b
removing internal since it's the default
vegaro Jun 25, 2021
e593073
moves headersInResponse after error != nil
vegaro Jun 25, 2021
cbea25e
move to private extension
vegaro Jun 28, 2021
6d98661
remove extra t
vegaro Jun 28, 2021
4882433
added line breaks
vegaro Jun 29, 2021
053cc22
dont include . if bundleID is nil
vegaro Jun 29, 2021
730b12b
s/responseObject/jsonObject
taquitos Jul 2, 2021
fcd283e
Linter errors
taquitos Jul 2, 2021
585b000
change do catch with a try?
vegaro Jul 7, 2021
2db4f9c
changes guard let with if let
vegaro Jul 7, 2021
a55a869
format RCHTTPCLient
vegaro Jul 7, 2021
41983f6
removes GET from function name
vegaro Jul 7, 2021
323dd8e
little refactor with guard let
vegaro Jul 8, 2021
a1b6b97
fix indentation
vegaro Jul 8, 2021
609bbe5
fix indentation
vegaro Jul 8, 2021
4efa180
extracts suiteNameBase
vegaro Jul 8, 2021
44ba816
removes get from function
vegaro Jul 9, 2021
e24debb
change test response
vegaro Jul 9, 2021
75a1cc1
space before {
vegaro Jul 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 6 additions & 2 deletions Examples/LegacySwiftExample/Configuration.storekit
View file
Open in desktop
@@ -1,4 +1,8 @@
{
"identifier" : "F256E58C",
"nonRenewingSubscriptions" : [

],
"products" : [
{
"displayPrice" : "199.99",
Expand Down Expand Up @@ -84,6 +88,6 @@
],
"version" : {
"major" : 1,
"minor" : 0
"minor" : 1
}
}
}
25 changes: 19 additions & 6 deletions ...codeproj/xcshareddata/xcschemes/WatchExample - StoreKit Config Files (Xcode 12+).xcscheme
View file
Open in desktop
Expand Up @@ -55,16 +55,18 @@
debugServiceExtension = "internal"
allowLocationSimulation = "YES"
notificationPayloadFile = "WatchExample Extension/PushNotificationPayload.apns">
<BuildableProductRunnable
runnableDebuggingMode = "0">
<RemoteRunnable
runnableDebuggingMode = "2"
BundleIdentifier = "com.apple.Carousel"
RemotePath = "/SwiftExample">
<BuildableReference
BuildableIdentifier = "primary"
BlueprintIdentifier = "2D54BF602437DED800FF4EE4"
BuildableName = "WatchExample.app"
BlueprintName = "WatchExample"
ReferencedContainer = "container:LegacySwiftExample.xcodeproj">
</BuildableReference>
</BuildableProductRunnable>
</RemoteRunnable>
<StoreKitConfigurationFileReference
identifier = "../Configuration.storekit">
</StoreKitConfigurationFileReference>
Expand All @@ -75,16 +77,27 @@
savedToolIdentifier = ""
useCustomWorkingDirectory = "NO"
debugDocumentVersioning = "YES">
<BuildableProductRunnable
runnableDebuggingMode = "0">
<RemoteRunnable
runnableDebuggingMode = "2"
BundleIdentifier = "com.apple.Carousel"
RemotePath = "/SwiftExample">
<BuildableReference
BuildableIdentifier = "primary"
BlueprintIdentifier = "2D54BF602437DED800FF4EE4"
BuildableName = "WatchExample.app"
BlueprintName = "WatchExample"
ReferencedContainer = "container:LegacySwiftExample.xcodeproj">
</BuildableReference>
</BuildableProductRunnable>
</RemoteRunnable>
<MacroExpansion>
<BuildableReference
BuildableIdentifier = "primary"
BlueprintIdentifier = "2D54BF602437DED800FF4EE4"
BuildableName = "WatchExample.app"
BlueprintName = "WatchExample"
ReferencedContainer = "container:LegacySwiftExample.xcodeproj">
</BuildableReference>
</MacroExpansion>
</ProfileAction>
<AnalyzeAction
buildConfiguration = "Debug">
Expand Down
25 changes: 19 additions & 6 deletions ...acySwiftExample/LegacySwiftExample.xcodeproj/xcshareddata/xcschemes/WatchExample.xcscheme
View file
Open in desktop
Expand Up @@ -55,33 +55,46 @@
debugServiceExtension = "internal"
allowLocationSimulation = "YES"
notificationPayloadFile = "WatchExample Extension/PushNotificationPayload.apns">
<BuildableProductRunnable
runnableDebuggingMode = "0">
<RemoteRunnable
runnableDebuggingMode = "2"
BundleIdentifier = "com.apple.Carousel"
RemotePath = "/SwiftExample">
<BuildableReference
BuildableIdentifier = "primary"
BlueprintIdentifier = "2D54BF602437DED800FF4EE4"
BuildableName = "WatchExample.app"
BlueprintName = "WatchExample"
ReferencedContainer = "container:LegacySwiftExample.xcodeproj">
</BuildableReference>
</BuildableProductRunnable>
</RemoteRunnable>
</LaunchAction>
<ProfileAction
buildConfiguration = "Release"
shouldUseLaunchSchemeArgsEnv = "YES"
savedToolIdentifier = ""
useCustomWorkingDirectory = "NO"
debugDocumentVersioning = "YES">
<BuildableProductRunnable
runnableDebuggingMode = "0">
<RemoteRunnable
runnableDebuggingMode = "2"
BundleIdentifier = "com.apple.Carousel"
RemotePath = "/SwiftExample">
<BuildableReference
BuildableIdentifier = "primary"
BlueprintIdentifier = "2D54BF602437DED800FF4EE4"
BuildableName = "WatchExample.app"
BlueprintName = "WatchExample"
ReferencedContainer = "container:LegacySwiftExample.xcodeproj">
</BuildableReference>
</BuildableProductRunnable>
</RemoteRunnable>
<MacroExpansion>
<BuildableReference
BuildableIdentifier = "primary"
BlueprintIdentifier = "2D54BF602437DED800FF4EE4"
BuildableName = "WatchExample.app"
BlueprintName = "WatchExample"
ReferencedContainer = "container:LegacySwiftExample.xcodeproj">
</BuildableReference>
</MacroExpansion>
</ProfileAction>
<AnalyzeAction
buildConfiguration = "Debug">
Expand Down