Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate RCHTTPStatusCodes #614

Closed
wants to merge 1 commit into from
Closed

Migrate RCHTTPStatusCodes #614

wants to merge 1 commit into from

Conversation

taquitos
Copy link
Contributor

@taquitos taquitos commented Jul 1, 2021

resolved #579

@taquitos taquitos changed the base branch from main to swift_migration July 1, 2021 22:59
@taquitos taquitos requested a review from a team July 1, 2021 22:59
taquitos
taquitos commented Jul 1, 2021
View reviewed changes
Purchases.xcodeproj/project.pbxproj Outdated
@@ -699,15 +699,16 @@
isa = PBXGroup;
children = (
2CD72940268A820E00BFC976 /* FoundationExtensions */,
B3DDB55726854850008CCF23 /* Public */,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a reorganization, alphabetical folders, then files, with the addition of Networking folder

@taquitos taquitos mentioned this pull request Jul 1, 2021
Closed
aboedo
aboedo reviewed Jul 2, 2021
View reviewed changes
Copy link
Member

@aboedo aboedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will conflict with #509, since that PR also does it. ETags is very close to ready to go, perhaps we should list out the stuff that gets migrated on that PR and assign them to @vegaro, then rebase from it?

@taquitos
Copy link
Contributor Author

taquitos commented Jul 2, 2021

@aboedo yeah, I see that conflict, but I think it's ok. #509 will be merged to main so we can ship before Swift migration. I'm happy to resolve this merge conflict after. The conflicts won't be huge.

@taquitos
Copy link
Contributor Author

This has been superseded by #509 and #640

@taquitos taquitos closed this Jul 10, 2021
@taquitos taquitos deleted the RCHTTPStatusCodes branch August 6, 2021 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aboedo aboedo aboedo left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate RCHTTPStatusCodes
2 participants
@taquitos @aboedo