Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue bot fixes #702

Merged
merged 2 commits into from Aug 3, 2021
Merged

issue bot fixes #702

merged 2 commits into from Aug 3, 2021

Conversation

aboedo
Copy link
Member

@aboedo aboedo commented Aug 3, 2021 •
edited

Lock bot:

  • removed swift-migration and test-backfill labels. They were wrong 🤦 but also, I think it's probably not a bad thing to lock these issues after they've been closed for over 7 days.

Stale bot:

  • updated swift-migration and test-backfill labels to the correct names, swift migration and test backfill (space instead of dash).

@aboedo aboedo requested a review from a team August 3, 2021 14:20
@aboedo aboedo self-assigned this Aug 3, 2021
beylmk
beylmk approved these changes Aug 3, 2021
View reviewed changes
Copy link
Contributor

@beylmk beylmk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖

beylmk
beylmk suggested changes Aug 3, 2021
View reviewed changes
Copy link
Contributor

@beylmk beylmk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks like you've done the reverse of what you mentioned in the PR comment though (removed labels from stale)

taquitos
taquitos previously approved these changes Aug 3, 2021
View reviewed changes
Copy link
Contributor

@taquitos taquitos left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😆
Ooo good catch @beylmk

@taquitos taquitos dismissed their stale review August 3, 2021 17:14

I was wrong

@aboedo
Copy link
Member Author

aboedo commented Aug 3, 2021

LOL I'm so glad I got the description right. Great catch! Updated

@aboedo aboedo requested review from beylmk and taquitos August 3, 2021 18:49
@aboedo aboedo mentioned this pull request Aug 3, 2021
Merged
@aboedo aboedo merged commit 0d9a9d5 into main Aug 3, 2021
@aboedo aboedo deleted the fix/issue_bot_label_name branch August 3, 2021 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beylmk beylmk beylmk approved these changes

@taquitos taquitos Awaiting requested review from taquitos

Assignees

@aboedo aboedo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aboedo @taquitos @beylmk