extracts readableErrorCode to userInfo #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
RevenueCat/purchases-hybrid-common#82 has been merged, but not deployed yet so holding on this one |
|
@vegaro purchases-hybrid-common update has been released, so this should be ready to go |
aboedo
approved these changes
Jul 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
readableErrorCode is inside the UserInfo of the error and not in the root of the object. When rejecting in React Native there's no way to pass anything else than a code, a message and an NSError. We were assuming
readableErrorCodeis in the root of the Error object, but it's actually in the user info property.This PR depends on this other PR.
Should fix #266