Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WiredComponent.getInitialProps -> Always async #70

Closed
gio-work opened this issue Jun 23, 2022 · 1 comment · Fixed by #77
Closed

WiredComponent.getInitialProps -> Always async #70

gio-work opened this issue Jun 23, 2022 · 1 comment · Fixed by #77

Comments

@gio-work
Copy link
Contributor

gio-work commented Jun 23, 2022

Hey there,

We noticed that WiredComponent.getInitialProps is sync on client and async on server. We would be interested in them being async on either or, since it's technically allowed in Next.JS

If this works for y'all, I'm happy to put out a PR.

Thanks!

@rrdelaney
Copy link
Member

Don't see any reason that it had to be synchronous, would happily accept a PR! Let's make sure that it's backwards compatible and we can return either the value itself or a promise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants