Hunk headers don't work with Swift

[lilyball]

Reviewable's diff hunk header detection only seems to show me top-level declarations, e.g. the class declaration. It doesn't recognize functions. Ideally it would recognize the nearest enclosing function or type definition, including nested functions/types.

[pkaminski]

Reviewable leverages highlightjs.org syntax coloring annotations to detect declarations in all supported languages, so it's possible that the Swift language definition there is misconfigured or incomplete. Since I don't know Swift, could you point me to any PR with Swift code and list a few lines that should be treated as declarations but aren't? Then I can look into what highlightjs does with them and report the bug upstream if appropriate. Thanks.

[lilyball]

Huh, I just found an old public PR that I was going to use, but it's actually showing the hunk headers as expected. The PR that I was reviewing that prompted this particular issue is a private one. I'll have to investigate a bit further to see if I can figure out what the difference is.

[veeamd]

I have the same issue.

[veeamd]

Sorry, it's a private PR, I can only show you some screenshots of the code.

After expanding the code:

[pkaminski]

These look like screenshots from github.com -- can you provide screenshots from Reviewable please?

[pkaminski]

Closing due to lack of activity.