New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add isset before strpos in colour code check #41

Merged

rahaddon merged 1 commit into master from fix/deprecated-null-argument

Apr 28, 2023

Contributor

Ben-Bromley commented Mar 22, 2023 •

edited

Loading

Passing null as the first argument of strpos is deprecated in php 8.1

This only happens when the product review widget star colour isn't set in the config.


          add isset before strpos in colour code check

1002dce

rahaddon merged commit 1b5577b into master

rahaddon deleted the fix/deprecated-null-argument branch

April 28, 2023 13:42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment