Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong MP calculation combine in multicellular editor when editing two (or more) cell types in a row #3413

Closed
84634E1A607A opened this issue Jun 15, 2022 · 4 comments
Closed

Wrong MP calculation combine in multicellular editor when editing two (or more) cell types in a row #3413

84634E1A607A opened this issue Jun 15, 2022 · 4 comments
Labels
bug C# difficult programming review stage:multicellular
Projects
Thrive Planning
Milestone
Release 0.6.4

Comments

@84634E1A607A
Copy link
Contributor

84634E1A607A commented Jun 15, 2022 •
edited

To reproduce (for example)

  1. Add two cell types (Stem, Stem2)
    image

  2. Modify Stem, delete Flagellum (The cost reads -2, but actually it costs 5)
    image

  3. Modify Stem2, add Flagellum
    image
    MP goes to 98. image

Debugging Info:
ActionHistory:image
Combined:image

Remove in one cell and Place in another is mis-combined to a move.
@hhyyrylainen hhyyrylainen added this to Backburner in Thrive Planning via automation Jun 16, 2022
@hhyyrylainen hhyyrylainen moved this from Backburner to High priority bugs / issues in Thrive Planning Jun 16, 2022
@Kashnox
Copy link
Contributor

Kashnox commented Oct 2, 2023

I wasn't able to reproduce this on master. It might have been fixed with the recent changes to the multicellular editor in PR #4483 because we no longer allow combining actions from different contexts.

@hhyyrylainen hhyyrylainen added this to the Release 0.6.4 milestone Oct 2, 2023
@buckly90
Copy link
Member

buckly90 commented Oct 3, 2023

I was able to reproduce the bug playing the 0.6.3 release, but following the exact same steps on master fails to reproduce.

So yeah it seems this might not be an issue anymore.

@hhyyrylainen
Copy link
Member

Alright let's close this then as the new context feature of cell edits should now prevent this incorrect action combining from happening.

Thrive Planning automation moved this from High priority bugs / issues to Done Oct 4, 2023
@hhyyrylainen
Copy link
Member

A new probable variant of this bug: #5010

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug C# difficult programming review stage:multicellular
Projects
Thrive Planning
  
Done
Milestone
Release 0.6.4
Development

No branches or pull requests
4 participants
@hhyyrylainen @Kashnox @buckly90 @84634E1A607A