Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Early multicellular body plan editor and cell editor can end up displaying at the same time #3910

Closed
hhyyrylainen opened this issue Dec 5, 2022 · 4 comments · Fixed by #4515

Comments

@hhyyrylainen
Copy link
Member

obviously they shouldn't be able to display at the same time but every now and then someone shows a screenshot of that happening, like this:

screenshot

This should be easy enough to fix once someone comes up reliable step of instructions that cause the bug to appear.

@hhyyrylainen
Copy link
Member Author

Here's potential instructions on how to trigger that (from this video: https://www.youtube.com/watch?v=_G5_akrWCtg):

  • Enter early multicellular
  • Place another stem cell
  • Duplicate the stem cell type
  • Place a cell of the duplicated type
  • Modify the stem cell type
  • Delete an organelle
  • Move an organelle
  • Switch to the editor tab (by pressing the tab button, not NEXT)
  • Place cell of stem type
  • Place a cell of the duplicated type
  • Modify the duplicated type again
  • Do the exact same edits to the modified type now as the stem type
  • Add an extra organelle of the removed type (different position than it was removed from)
  • Switch back to the editor tab
  • Place a cell of the modified type
  • Place a cell of the stem type
  • Switch back to the cell editor tab
  • Move the organelle you last placed to the same position (but different rotation) than it was deleted from earlier
  • Switch back to the editor tab
  • Try to place a cell of the duplicated type (but fail due to not enough MP)
  • Select the stem cell type
  • Hit undo
  • See the bug with both the cell and body plan editor world objects being visible

@84634E1A607A
Copy link
Contributor

A clear seq:

  1. Add a cell
  2. Move that cell
  3. Go to cell editor
  4. Hit undo

@hhyyrylainen
Copy link
Member Author

Apparently this same issue can also happen in the late multicellular editor, where I suspect the logic bug is the same.

screenshot

@Kashnox
Copy link
Contributor

Kashnox commented Oct 6, 2023

The same root issue of the multicellular editor not switching between tabs when actions are undone/redone can lead to a deleted cell type being shown in the Cell tab following these steps:

  1. Duplicate any cell type
  2. Modify that cell type
  3. Undo the duplication while the Cell tab is still open

This problem should also be fixed with this issue.

@hhyyrylainen hhyyrylainen added this to the Release 0.6.4 milestone Oct 6, 2023
@hhyyrylainen hhyyrylainen moved this from Low priority bugs / issues to High priority bugs / issues in Thrive Planning Oct 6, 2023
@hhyyrylainen hhyyrylainen moved this from High priority bugs / issues to In progress in Thrive Planning Oct 7, 2023
@hhyyrylainen hhyyrylainen moved this from In progress to started but stuck (help wanted) in Thrive Planning Jan 12, 2024
Thrive Planning automation moved this from started but stuck (help wanted) to Done Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment