Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create 2D icon for Glucose Phosphatase (RuBisCo) #4221

Closed
hhyyrylainen opened this issue Mar 14, 2023 · 10 comments
Closed

Create 2D icon for Glucose Phosphatase (RuBisCo) #4221

hhyyrylainen opened this issue Mar 14, 2023 · 10 comments

Comments

@hhyyrylainen
Copy link
Member

hhyyrylainen commented Mar 14, 2023

https://forum.revolutionarygamesstudio.com/t/new-organelle-for-storing-atp-as-glucose/1001

Code implementation side of this issue: #4222

@Kertit
Copy link
Contributor

Kertit commented Mar 29, 2023

Model + Texture is done (still waiting for texture color validation)
As for 2D icon it seems "Bolsa" done one ?
image

@hhyyrylainen
Copy link
Member Author

Is the model finished (around 300 triangles, exported as .glb)? If so it should be uploaded to the devcenter so that the files are not lost (also the same applies to the icon once it is finished, I think I only saw a low res preview of what the icon could be): https://dev.revolutionarygamesstudio.com/files/Asset%20development/Organelles

@Kertit
Copy link
Contributor

Kertit commented Mar 29, 2023

Model is 480 tris, is that too much?

@hhyyrylainen
Copy link
Member Author

It's a bit on the higher end, so a bit lower would be optimal, because with that count I think this would end up being the "heaviest" model in the game, and the rubisco organelle is not planned to be more than one hex. So much more screen space taking up models are using less triangles.

@hhyyrylainen hhyyrylainen moved this from To do to In progress in Graphics Tasks Mar 29, 2023
@Kertit
Copy link
Contributor

Kertit commented Mar 29, 2023

Now 290 Tris
Looks a little bit less smooth. Your thought?

image

@hhyyrylainen
Copy link
Member Author

It still looks about the same to me so that's much better. Probably better to ask on the dev discord graphics channel (well at least until some conclusion is reached here: https://forum.revolutionarygamesstudio.com/t/graphics-tasks-work-flow-discussion/1012) for feedback as only programmers hang out on Github.

@Kertit
Copy link
Contributor

Kertit commented Mar 30, 2023

Model + texture Uploaded to DevCenter

@hhyyrylainen
Copy link
Member Author

For reference the files are uploaded here: https://dev.revolutionarygamesstudio.com/files/Asset%20development/Organelles/RuBisCO

Direct link for texture and .glb (our organelle shaders currently only support an albedo map). Would be nice if some programmer could verify in Godot that the files are fine...

Now we just need the finished 2D icon for the organelle.

@hhyyrylainen hhyyrylainen changed the title Create model, texture and 2D icon for RuBisCo Create 2D icon for RuBisCo Mar 30, 2023
@hhyyrylainen hhyyrylainen moved this from Backburner to In progress in Thrive Planning Mar 30, 2023
@hhyyrylainen
Copy link
Member Author

Icon is now also uploaded here: https://dev.revolutionarygamesstudio.com/api/v1/download/39369

Thrive Planning automation moved this from In progress to Done Mar 31, 2023
Graphics Tasks automation moved this from In progress to Done Mar 31, 2023
@hhyyrylainen hhyyrylainen changed the title Create 2D icon for RuBisCo Create 2D icon for Glucose Phosphatase (RuBisCo) Apr 28, 2023
@hhyyrylainen
Copy link
Member Author

The organelle was renamed to Glucose Phosphatase but I think we can still use the existing graphics assets for it, just need to rename the files for the new organelle name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

2 participants