Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix checking command existence #1602

Merged
merged 1 commit into from Aug 3, 2023
Merged

Fix checking command existence #1602

merged 1 commit into from Aug 3, 2023

Conversation

ferki
Copy link
Member

@ferki ferki commented Aug 3, 2023 •
edited

This PR is a proposal to fix #1601 by checking if the command path actually exists as a file.

Checklist

  • based on top of latest source code
  • changelog entry included
  • automated tests pass
  • git history is clean
  • git commit messages are well-written

@ferki ferki merged commit c6e38f9 into master Aug 3, 2023
89 checks passed
@ferki ferki deleted the can_run_validation branch August 3, 2023 18:56
@gregoa gregoa mentioned this pull request Aug 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

t/can_run.t fails on some Windows hosts
1 participant
@ferki