Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stri_prepare_arg_* retvals are not PROTECTed from gc #112

Closed
gagolews opened this issue Nov 1, 2014 · 1 comment
Closed

stri_prepare_arg_* retvals are not PROTECTed from gc #112

gagolews opened this issue Nov 1, 2014 · 1 comment
Assignees
@gagolews
Labels
bug
Milestone
stringi-0.3

Comments

@gagolews
Copy link
Owner

gagolews commented Nov 1, 2014

stri_prepare_arg_ may return e.g. results generated by Rf_allocVectors - we never protect them, and that's a serious bug
@gagolews gagolews added the bug label Nov 1, 2014
@gagolews gagolews self-assigned this Nov 1, 2014
@gagolews gagolews added this to the stringi-0.3 milestone Nov 1, 2014
gagolews added a commit that referenced this issue Nov 4, 2014
@gagolews
BUG #112 fixing ongoing
fc8bd18
gagolews added a commit that referenced this issue Nov 4, 2014
@gagolews
BUG #112 fixing ongoing
d9c7f67
gagolews added a commit that referenced this issue Nov 4, 2014
@gagolews
BUG #112 fixing ongoing
aac35bb
gagolews added a commit that referenced this issue Nov 5, 2014
@gagolews
BUG #112 fixing ongoing
ce98cfc
gagolews added a commit that referenced this issue Nov 5, 2014
@gagolews
BUG #112 fixed (I hope so)
b45e79b
@gagolews
Copy link
Owner Author

gagolews commented Nov 5, 2014

It shall be fixed now. Closing.

@gagolews gagolews closed this as completed Nov 5, 2014
gagolews added a commit that referenced this issue Nov 19, 2014
@gagolews
#112 cont'd
30b4760
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gagolews gagolews

Labels
bug
Projects
None yet
Milestone
stringi-0.3
Development

No branches or pull requests
1 participant
@gagolews