Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Last bit omitted in rawdemod #240

Open
ViRb3 opened this issue Jul 11, 2019 · 7 comments
Open

Last bit omitted in rawdemod #240

ViRb3 opened this issue Jul 11, 2019 · 7 comments
Labels
bug Something isn't working

Comments

@ViRb3
Copy link
Contributor

ViRb3 commented Jul 11, 2019

Following @doegox's commands for manually reading a hitag2 UID:

lf cmdread d 50 z 166 o 116 c 000111
data ltrim 200
data norm
data rawdemod am
data printdemodbuffer o 5 x

Using the hitag2 module:

lf hitag read 26
// or
lf hitag info
// or
if hitag read 21 ... (makes dump)

Will result in the same UID, however, the last bit is 0 using the manual read, while it is a 1 using the hitag2 module. I tested this on two different cards, however, I cannot verify which one is the true UID. I suspect the rawdemod is at fault since the hitag2 module data has worked for me so far.

Potentially related:

@doegox
Copy link
Contributor

doegox commented Jul 11, 2019

Good catch, you're right.
I tried on a car key to get another ID and by chance its last bit is a 1.
My manual steps return an ID=xxxx4D6A but another reader (ACG-LF) returns xxxx4D6B.
Here we see the Manchester decoder stopped before the last weaker "1"(HL) bit:
Screenshot from 2019-07-11 17-50-46
(note that lf hitag read 26 could not see my key)

@doegox doegox added the bug Something isn't working label Jul 11, 2019
@iceman1001
Copy link
Collaborator

there are most certain same issues with NR demod ..

@iceman1001
Copy link
Collaborator

@ViRb3 Some news?

@ViRb3
Copy link
Contributor Author

ViRb3 commented Oct 8, 2019

I'm afraid I'm not competent enough to fix this, at least not without some research that I can't do right now. I was hoping @doegox has a better clue at what's wrong

@doegox
Copy link
Contributor

doegox commented Oct 8, 2019

😙

@iceman1001 iceman1001 mentioned this issue Jun 15, 2020
@iceman1001
Copy link
Collaborator

@doegox what is your output from car key and hitag today?

@doegox
Copy link
Contributor

doegox commented Sep 16, 2020

Manual decoding gets still last bit wrong, but lf hitag reader works fine

[usb] pm3 --> lf cmdread d 50 z 166 o 116 c 000111
[+] Sending command...
[#] Done, saved 42216 out of 0 seen samples at 8 bits/sample

[+] downloading response signal data
[usb] pm3 --> data ltrim 200
[usb] pm3 --> data norm
[usb] pm3 --> data rawdemod am
11111011100110111101001001101011
0101.0
[usb] pm3 --> data printdemodbuffer o 5 x
[+] DemodBuffer: xxxx4D6A[3]

[usb] pm3 --> lf hitag read 26
[+]  UID: xxxx4d6b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants