Rework hitag2 read/write help

[ViRb3]

And add default keys

[iceman1001]

Hm.. so there is no write / read on hitag S?

[ViRb3]

Sure there is? I only reworded the help text.

[iceman1001]

Because your rewording removes "read all pages" etc from the help text..
So it that not true anymore?

[ViRb3]

Oh, no, it's still valid. I just assumed it is obvious that all commands under read will read, and under write will write. Think I should add that back to the help?

[iceman1001]

Not sure its much clearer with your suggested changes.
hitag reader... acting as a reader doesn't mean read , read all pages, etc..

[ViRb3]

Sure, I'll re-write it to be clearer.

[ViRb3]

How does that look like? :)

[doegox]

looks good, thanks

[iceman1001]

Great!

[pwpiwi]

Are there other default passwords? It doesn't work for me on a brand new Hitag2 tag:

[usb] pm3 --> lf hitag reader
Hitag reader functions
Usage: lf hitag reader [h] <reader function #>
Options:
       h               This help
   HitagS (0*)
      01 <nr> <ar>     Read all pages, challenge mode
      02 <key>         Read all pages, crypto mode. Set key=0 for no auth
   Hitag1 (1*)
      Not implemented
   Hitag2 (2*)
      21 <password>    Read all pages, password mode. Default: 4D494B52 ("MIKR")
      22 <nr> <ar>     Read all pages, challenge mode
      23 <key>         Read all pages, crypto mode. Key format: ISK high + ISK low. Default: 4F4E4D494B52 ("ONMIKR")
      25               Test recorded authentications
      26               Just read UID
[usb] pm3 --> lf hitag reader 21 4d494b52
#db# List identifier in password mode
#db# Password failed!
[usb] pm3 --> lf hitag reader 26
[+] Valid Hitag2 tag found - UID: aa8e6b11

[iceman1001]

Better to use forum for questions.

[ViRb3]

@pwpiwi those are the only default keys I'm afraid. I can confirm they work on my new Hitag2 cards. The distance and placement of the tag to the antenna is incredibly important, try moving it around and retrying the read.

[pwpiwi]

Indeed, I could make it work after some fiddling! While lf hitag 26 works at different distances, lf hitag 23 is more sensitive to distance (which makes me think that sending is the issue rather than receiving). In general, possible distances are quite low compared to commercial LF readers.

[doegox]

Indeed @pwpiwi lf hitag suffers from two problems: reading distance (while manually I could achieve much large distances) and last bit wrong/missing, see #124 and #240

[ViRb3]

@pwpiwi any chance you could send that upstream hitag love (PR) back to this repo? I could use your refactor if I'm doing more work on hitag.

[pwpiwi]

No need to send the latest changes from official to RRG. The PR adds latest additions (password write) formatting and refactoring from RRG to official. 😃

[ViRb3]

I meant your touches, e.g. the commands extracted to the protocols header. That's good stuff :)

[pwpiwi]

I had added this more or less for documentation only. Feel free to copy & paste. As discussed in #18 there is no easy way to reuse PRs and/or commits.