New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Imputation using MLE #100
Comments
@lgatto or @cvanderaa , can you please have a look? |
Thank you @AndrMenezes - I had a quick look and
|
@lgatto , thank you for the reply,
Note that, if you use |
Thank you very much! Your issue raised a really good point that is actually applicable to many other imputation methods (and has only been discussed in parts). In addition to your fixes, I will expand on this in the manual page. |
@lgatto Thanks. Notice that this assumption (columns: variables and rows: realizations of the variables) was briefly mentioned in Section 3 of Hastie et al. (2001), where the authors emphasized this data structure for imputation using regression. |
Indeed, and for KNN for example, using features x samples or sample x features makes strong assumptions on the downstream analyses. It will take some time until I close the issue, but it will be done for sure, including a section in the documentation. |
Hi @AndrMenezes - thanks again for your issue and useful discussions. There's now a new impute_mle2() function that uses |
Dear all,
Thanks for the package.
I have two comments concerning the imputation MLE method:
impute_mle
function shouldn't be transpose? Since the rows ofx
should correspond to the observational unit (samples) and the columns to variable (proteins/peptides).norm
package is an old R package and there are some limitation, e.g., it does not work reliably when the number of variables exceeds 30. Please, consider take a look atnorm2
package.The text was updated successfully, but these errors were encountered: