--dry-run parameter ignored and album still created on export #1440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated comment to index instead of table
- output to stdout console re: status of osxphotos export database - clarifying which type of database the version is being shown for and reducing it to a single line instead of two
Updated assert re:search to match updated output statement in osxphotos/cli/export.py
album created even when --dry-run parameter is used. i.e. osxphotos export --dry-run --add-missing-to-album ABC, the dry-run parameter is ignored and album ABC is created.
|
Thank you! |
|
@rajscode I appreciate the contributions! In the future, please create a branch on your fork then push the PR from that branch. It makes it easier in the log that way to see what came from where. Here's an article on the process. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
album created even when --dry-run parameter is used.
i.e.
osxphotos export --dry-run --add-missing-to-album ABC
The --dry-run parameter is ignored and album ABC is created.