Fixes for iam__enum users/roles modules #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update the path of the default-word-list.txt file for the new pacu structure. * Other minor improvements.
RyanJarv
commented
Jun 2, 2021
| @@ -111,7 +112,7 @@ def run(args, role_name, pacu_main, iam): | |||
| return data | |||
| else: | |||
| print(' Unhandled error: {}'.format(str(error))) | |||
| return data | |||
| raise error | |||
There was a problem hiding this comment.
I don't think there's any reason to return the data here if the module fails, doing so also prevents the error from being logged.
RyanJarv
commented
Jun 2, 2021
| @@ -159,7 +160,7 @@ def main(args, pacu_main): | |||
| iam: 'mypy_boto3_iam.IAMClient' = pacu_main.get_boto3_client('iam') | |||
|
|
|||
| if args.role_name: | |||
| role_name = args.role_name | |||
| role_name = args.role_name.split('/')[-1] # Handle ARN's if that was passed for whatever reason. | |||
There was a problem hiding this comment.
Works the same as before but handles cases where a role ARN was passed instead of a name.
DaveYesland
approved these changes
Jun 3, 2021
RyanJarv
pushed a commit
that referenced
this pull request
Aug 3, 2021
* Update the path of the default-word-list.txt file for the new pacu structure. * Other minor improvements.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pacu structure.