Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V1.6.2 - Stalled Indexing message #656

Merged
merged 6 commits into from
Dec 6, 2018
Merged

V1.6.2 - Stalled Indexing message #656

merged 6 commits into from
Dec 6, 2018

Conversation

m4rk3r
Copy link
Member

@m4rk3r m4rk3r commented Dec 5, 2018

Add a "Additional Info" message if player indexing stalls at 100% to allow user to view any errors.

@m4rk3r m4rk3r requested a review from ikreymer December 5, 2018 17:56
@codecov
Copy link

codecov bot commented Dec 6, 2018

Codecov Report

Merging #656 into master will increase coverage by 0.49%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #656      +/-   ##
==========================================
+ Coverage   77.09%   77.59%   +0.49%     
==========================================
  Files          61       61              
  Lines        7604     7827     +223     
  Branches     1173     1261      +88     
==========================================
+ Hits         5862     6073     +211     
- Misses       1356     1361       +5     
- Partials      386      393       +7
Impacted Files Coverage Δ
webrecorder/webrecorder/models/recording.py 88.33% <0%> (-0.84%) ⬇️
webrecorder/webrecorder/models/user.py 92.73% <0%> (+2.47%) ⬆️
webrecorder/webrecorder/contentcontroller.py 83.62% <0%> (+2.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 222be16...c83d36a. Read the comment docs.

@ikreymer ikreymer merged commit eff9c21 into master Dec 6, 2018
ikreymer pushed a commit to webrecorder/webrecorder-player that referenced this pull request Dec 6, 2018
* Update electron to latest, bump webrecorder submodule to include Rhizome-Conifer/conifer#656
@ikreymer ikreymer deleted the v1.6.2 branch December 10, 2018 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants