Desktop Apps Nav Bar Update #741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ikreymer
commented
Aug 21, 2019
ikreymer
commented
- Move nav bar from app/player header to be next to location bar.
- Consistent both in desktop app and player
- Nav buttons reset when webview is initialized.
- Ensure autopilot apis not called in replay mode (eg. in player)
- Make location bar corners rounded
- fix styling - add to patch mode - also add rounded corner to location bar
- remove player nav, using same nav in both - autopilot: ensure autopilot checks not triggered in replay (and in player) - ensure nav reset when webview loads
Codecov Report
@@ Coverage Diff @@
## master #741 +/- ##
==========================================
+ Coverage 73.74% 73.88% +0.13%
==========================================
Files 65 65
Lines 8373 8373
Branches 1310 1310
==========================================
+ Hits 6175 6186 +11
+ Misses 1802 1795 -7
+ Partials 396 392 -4
Continue to review full report at Codecov.
|
m4rk3r
approved these changes
Aug 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.