Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new homepage layout #756

Merged
merged 9 commits into from Oct 25, 2019
Merged

Add new homepage layout #756

merged 9 commits into from Oct 25, 2019

Conversation

m4rk3r
Copy link
Member

@m4rk3r m4rk3r commented Oct 24, 2019

  • Display standalone recorder widget based on ANON_DISABLED env var

@m4rk3r m4rk3r requested a review from ikreymer October 24, 2019 21:14
@codecov
Copy link

codecov bot commented Oct 25, 2019

Codecov Report

Merging #756 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #756      +/-   ##
==========================================
+ Coverage   74.03%   74.05%   +0.02%     
==========================================
  Files          65       65              
  Lines        8568     8568              
  Branches     1339     1339              
==========================================
+ Hits         6343     6345       +2     
+ Misses       1823     1822       -1     
+ Partials      402      401       -1
Impacted Files Coverage Δ
webrecorder/webrecorder/models/recording.py 89.68% <0%> (+0.79%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3100054...2175355. Read the comment docs.

@ikreymer ikreymer merged commit 867822e into master Oct 25, 2019
@nikisakovich
Copy link

RIP anonymous uploads.. (anonDisabled)
Guess someone was exploiting this functionality?

@ikreymer
Copy link
Collaborator

@nikisakovich Uploads actually always required an account.
Yes, we've set the ANON_DISABLED=1 flag on webrecorder.io as that functionality doesn't really make sense as we have the desktop app.
If you want to make an archive on webrecorder.io, you should make an account.
If you want to archive on your own anonymously, just use Webrecorder Desktop

@m4rk3r m4rk3r deleted the new-hp branch October 31, 2019 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants