Upload fix #769
Merged
Upload fix #769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- limit pages and bookmarks to 10000 - add settings to limit bookmarks and pages separately - include page and bookmark creation in progress bar before, page/bookmark creation was taking a long time but not included in progress update should fix #768, likely webrecorder/webrecorder-player#87, webrecorder/webrecorder-player#78, webrecorder/webrecorder-player#86
- correct page filter - optimize: use zscan_iter() for iterating over pages, add polyfill for fakeredis to still use zrange
Codecov Report
@@ Coverage Diff @@
## master #769 +/- ##
==========================================
- Coverage 74.04% 73.92% -0.13%
==========================================
Files 65 65
Lines 8570 8589 +19
Branches 1339 1342 +3
==========================================
+ Hits 6346 6349 +3
- Misses 1823 1839 +16
Partials 401 401
Continue to review full report at Codecov.
|
ikreymer
added a commit
to webrecorder/webrecorder-player
that referenced
this pull request
Nov 10, 2019
* Fix missing 'preload.js', was not bundled correctly * Add Flash version display to version stack * Update to pywb 2.4.0 (rc1) * Fix loading of large files, include page indexing in progress bar (Rhizome-Conifer/conifer#769) * Latest WR submodule with various additional fixes. * Update to Electron 6.1.4 * Bump version to 1.8.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for upload/import functionality. Limit total number of pages and bookmarks, and include bookmark import in the progress.
Previously, bookmark/page processing was taking significant amount of time, while progress bar was at 100%, resulting in confusion/seeming that app has stalled.