Query Overview v2.1.1 #148
Conversation
|
@pburnsdata , in retrospect it was a terrible idea to add unit tests. Took forever, required importing every d3 function explicitly, and was extremely frustrating. You can ignore the explicit import file changes for the most part. |
| @@ -25,5 +25,5 @@ export default function onInit() { | |||
| removeInvalidControls.call(this); | |||
|
|
|||
| //Initialize listing. | |||
| this.listing.init(this.raw_data); | |||
| this.listing.init(this.raw_data, this.listing.test); | |||
There was a problem hiding this comment.
@samussiah whats going on with this guy?
There was a problem hiding this comment.
webcharts has logic that expects the containing element to have been rendered before it proceeds. but the headless browser we use for testing doesn't actually render the page so there's some logic in init that avoids the rendered logic when running unit tests.
There was a problem hiding this comment.
gotcha gotcha - makes sense
|
There actually seems to be an IE issue with destroy. Spencer is looking at it. |
|
Destroy issue in IE is fixed, all good. |
Issues
Closes #147