Add x-axis tick label rotation functionality with setting... #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwildfire
suggested changes
Jan 10, 2017
| }; | ||
|
|
||
| // Replicate settings in multiple places in the settings object | ||
| export function syncSettings(settings){ | ||
| settings.y.column = settings.value_col; | ||
| settings.x.column = settings.time_cols[0]; | ||
| settings.x.type = settings.x.column === 'DY' |
There was a problem hiding this comment.
I'm a little worried about having a hard coded variable name here ("DY"). What happens when the user specifies a different set of time_cols?
What if we had time_cols specified like this: time_cols: [{value_col:"VISITN", axis_type:"ordinal"}, {value_col:"DY", axis_type:"linear}, ...], then this area becomes:
settings.x.column = settings.time_cols[0].value_col;
settings.x.type = settings.time_cols[0].axis_type;
There was a problem hiding this comment.
I like that approach a helluva lot more.
This was referenced Jan 10, 2017
…axis tick label rotation, and vertical spacing.
|
Merged branch |
jwildfire
approved these changes
Jan 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…
rotate_x_tick_labels.Closes #17
Closes #20 by dynamically defining
x.type.