-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
modify dict implementation, fix typo #65
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Jeez. How did this ever work? Looks great - thanks so much!
The CI failures look like they're likely an issue with a new version of pytest. I've triggered a build on master to see if we get the same issue. |
Have a fix in #67. We can merge this in once that is merged into master |
Merge in master
Note this PR is waiting on dallen5#2 |
merge master into update-set-env-var
@delgadom I merged in those changes, looks like this is passing tests (which seem to have sped up 5-10x??) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sweet thank you!
flake8 rhg_compute_tools tests docs
This updates the handling of the
env_items
parameter inget_cluster()
, changing the dictionary unpacking tofor k, v in env_items.items()
instead offor k, v in env_items.values()
.Also, this fixes a typo in the deprecated list-of-dicts implementation (from
isintance
toisinstance
).Finally, the docstring is updated to match the dict implementation rather than the deprecated list-of-dicts implementation.