Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modify dict implementation, fix typo #65

Merged
merged 3 commits into from
Jul 17, 2020

Conversation

dallen5
Copy link
Contributor

@dallen5 dallen5 commented May 19, 2020

This updates the handling of the env_items parameter in get_cluster(), changing the dictionary unpacking to for k, v in env_items.items() instead of for k, v in env_items.values().

Also, this fixes a typo in the deprecated list-of-dicts implementation (from isintance to isinstance).

Finally, the docstring is updated to match the dict implementation rather than the deprecated list-of-dicts implementation.

Copy link
Member

@delgadom delgadom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jeez. How did this ever work? Looks great - thanks so much!

@delgadom
Copy link
Member

The CI failures look like they're likely an issue with a new version of pytest. I've triggered a build on master to see if we get the same issue.

@delgadom
Copy link
Member

Have a fix in #67. We can merge this in once that is merged into master

@delgadom delgadom mentioned this pull request Jul 14, 2020
@delgadom
Copy link
Member

Note this PR is waiting on dallen5#2

merge master into update-set-env-var
@dallen5
Copy link
Contributor Author

dallen5 commented Jul 16, 2020

@delgadom I merged in those changes, looks like this is passing tests (which seem to have sped up 5-10x??)

Copy link
Member

@delgadom delgadom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweet thank you!

@delgadom delgadom merged commit e51e38e into RhodiumGroup:master Jul 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting environment variables on remote cluster does not work
2 participants