Added support for extra attributes for logging.LogRecord #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would it be better to use an |
|
@tclancy I have implemented your future-proofing idea! |
|
Thanks, would it be possible to also add a test/ tests to prove this new behavior works as intended? |
steven-lee-qadium
force-pushed
the
add-extra-log-record
branch
from
d24d826
to
b4b02af
Compare
|
Note that the failing test is mentioned in #24 that is an existing regression in the test - it would be nice for this to be merged still. |
|
Does this need to be updated now or is it obsolete? |
|
@tclancy Remerged master with test fix, so now everything is ready to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows access to request and/or response objects within each LogRecord by default, as well as allowing for easy inheritance configuration with the extra dict construction pulled out into its own method.
Note allows log filters to be able to print out information specific to individual requests, such as user.