Fix ARS decimal and thousand separators and add testable examples #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unkiwii
changed the title
Also fixed README.md examples that were outdated
Rhymond
approved these changes
Mar 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Argentina we use the decimal comma (,) and thousands separator is the point (.)
An example of money written in Argentina using ARS (Argentine Peso): $1.234.567,89
https://en.wikipedia.org/wiki/Decimal_separator#Countries_using_decimal_comma
https://en.wikipedia.org/wiki/Decimal_separator#Examples_of_use
Also added testable examples at
money_example_test.go. This examples are the same ones in the README, but they can be found in the package documentation.