Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go 1.13 - Use go/token.IsIdentifier Function for transform.ValidIdentifierKeys #1

Open
Rican7 opened this issue Jun 7, 2019 · 0 comments
Open

Go 1.13 - Use go/token.IsIdentifier Function for transform.ValidIdentifierKeys #1

Rican7 opened this issue Jun 7, 2019 · 0 comments
Assignees
@Rican7
Labels
enhancement New feature or request

Comments

@Rican7
Copy link
Owner

Rican7 commented Jun 7, 2019

Go 1.13 is adding a new IsIdentifier function to the go/token package in the standard library:

We could use that for either the logic in transform.ValidIdentifierKeys or at least the test, if we don't want to actually import go/token for the "distributed" package.
@Rican7 Rican7 added the enhancement New feature or request label Jun 7, 2019
@Rican7 Rican7 self-assigned this Jun 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Rican7 Rican7

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Rican7