Chore - Remove Glosbe Source #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems that Glosbe has killed their API, therefore removing the usefulness of this source. Bummer. :(
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the "Glosbe" source.
It hasn't been working properly for a bit, with the API just seemingly having been removed... 馃槥
It seems like there's still some sort of Glosbe API available...
... but trying to discover a new un-documented API brings me nothing but errors, and the original API just fails
... Sooooo, I guess it's time to remove the Glosbe source, which this PR does. To be honest, it was the worst data-set and required awkward HTML stripping even though it was a JSON API... soooo, good riddance I guess!
The only real reason I included it as a source in the first place is that it didn't require any API key or anything, so it worked as a kind of fallback/default so that people didn't have to immediately create an account for Oxford/Merriam-Webster after installing this app, but that's been remedied with the introduction of the new "Free Dictionary API" source in #24 (which is a far better data-set/source anyway), so this isn't a real loss at all. 馃槂
See ya! 鉁岋笍