Feature - Dictionary Word Search and Empty Define Result Fallback #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consistency!
Now, when a word is attempted to be defined, but the source returns an empty result, then a search will be conducted to show suggestions if the source implements an optional interface. Yay!
Rican7
force-pushed
the
feature/dictionary-word-search
branch
from
c17ee07
to
47f2ae3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ok, this is a cool one...
This PR adds a couple of main features: the optional capability for sources to expose a word search, and an automatic fallback to using that word search and displaying those results when an otherwise empty result is returned from a define action.
Now, when a word is attempted to be defined, but the source returns an empty result, then a search will be conducted to show suggestions if the source implements an optional interface. Yay!