Fixes issue with Microsoft Excel converting boolean values to all caps #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s, which breaks the dynamic typing feature for boolean values.
|
Hm, this has been addressed before back in the 3.x days. But somehow this commit got reverted, as I can't find the logic in HEAD. So thanks for bringing this to my attention, it's definitely a bug. I'll merge this in as soon as I submit the same change to Papa Parse - and add the associated tests back. This open PR will serve as a reminder... |
|
Gentle reminder... :) |
|
Sorry! I've been swamped lately. There's a 3-day weekend coming up, maybe I can get around to it then. |
mholt
added a commit
that referenced
this pull request
Feb 23, 2015
Fixes issue with Microsoft Excel converting boolean values to all caps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue with Microsoft Excel converting boolean values to all caps which breaks the dynamic typing feature for boolean values.