Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support optional chaining #45

Merged
merged 2 commits into from
Jun 11, 2020
Merged

support optional chaining #45

merged 2 commits into from
Jun 11, 2020

Conversation

Conduitry
Copy link
Collaborator

@Conduitry Conduitry commented Jun 11, 2020

Resolves #43. This has a couple of TypeScript workarounds so we don't need to wait for whenever @types/estree is going to be updated.

This handles ChainExpressions by just printing its expression object, and adds handling to CallExpression and MemberExpression for when optional is true.

@Conduitry Conduitry merged commit 1b9267c into Rich-Harris:master Jun 11, 2020
@Conduitry Conduitry deleted the gh-43 branch June 11, 2020 20:02
@tanhauhau
Copy link
Contributor

Created an PR to @types/estree DefinitelyTyped/DefinitelyTyped#45470

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support optional chaining
2 participants