Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stop distributing unused cjs #77

Merged
merged 2 commits into from Jun 10, 2023
Merged

stop distributing unused cjs #77

merged 2 commits into from Jun 10, 2023

Conversation

benmccann
Copy link
Contributor

@benmccann benmccann commented Jun 9, 2023 •
edited

exports has:

	"exports": {
		"import": "./src/index.js"
	},

Which means that dist is unnecessary

Will hopefully make learn.svelte.dev load a bit faster...

@Rich-Harris Rich-Harris merged commit 58b8be1 into Rich-Harris:master Jun 10, 2023
1 check passed
@Rich-Harris
Copy link
Owner

dist is unnecessary but we still need the build step, it generates the types

@MrHBS
Copy link

MrHBS commented Jun 10, 2023 •
edited

I think this can be simplified to "exports": "./src/index.js"?

@benmccann benmccann deleted the no-more-cjs branch June 10, 2023 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rich-Harris Rich-Harris Rich-Harris approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@benmccann @Rich-Harris @MrHBS