Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update @types/estree@0.0.45 #9

Merged
merged 1 commit into from
Jun 26, 2020

Conversation

tanhauhau
Copy link
Contributor

No description provided.

@Conduitry
Copy link

Is this going to create a problem whenever any consumer of is-reference wants to update its version of the ESTree types? Should this just use a broader semver range? I think even using * should be pretty safe because I really don't see something like the ESTree spec ever doing something that's not backwards compatible.

@Conduitry
Copy link

Actually is there a reason for this to be a prod dependency at all?

@tanhauhau
Copy link
Contributor Author

Actually is there a reason for this to be a prod dependency at all?

Well, I would assume it as peerDependency, you need it if you are using typescript, or else it would complain that @types/estree is missing, but for normal JS usage, it works fine without this dependency.

@Rich-Harris Rich-Harris merged commit 4a8dc0f into Rich-Harris:master Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants