-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't emit source mappings for removed strings. #159
Conversation
@Rich-Harris Please take a look. If the approach in this PR is incorrect you can use the following to verify your results for a different fix: Here are the dumps of the original incorrect test source maps using
Notice the collisions of the generated line/column combinations for the respective tests above:
Here are the dumps of the altered source map tests in this PR without the collisions and without the mappings for the dropped characters:
|
Fixes #149 Also fixes two incorrect test results and the rollup issue: rollup/rollup#3001
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the late response — the fix looks great to me! Although I don't fully understand what's going on in the mappings code in general, so it would be great to get another pair of eyes on this — @guybedford maybe?
Any news on this one? |
Fixes #149
Also fixes two incorrect test results and the rollup issue:
rollup/rollup#3001