Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows problems #3

Closed
Rich-Harris opened this issue Feb 11, 2015 · 0 comments
Closed

Windows problems #3

Rich-Harris opened this issue Feb 11, 2015 · 0 comments
Labels
bug

Comments

@Rich-Harris
Copy link
Owner

There are a couple of places where we're using '/' instead of path.sep. Not sure that they can be blindly replaced as the paths could be relative file paths or relative URLs. DAMN YOU WINDOWS

https://github.com/Rich-Harris/sorcery/blob/master/src/Node.js#L146
https://github.com/Rich-Harris/sorcery/blob/master/src/utils/getRelativePath.js#L4-L5
https://github.com/Rich-Harris/sorcery/blob/master/src/utils/getRelativePath.js#L19

See ractivejs/ractive#1706
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Rich-Harris