Skip to content
This repository has been archived by the owner on Dec 3, 2022. It is now read-only.

Increased segment value range from Int16 to Int32 #77

Merged
merged 1 commit into from Nov 21, 2018

Conversation

t2t2
Copy link
Contributor

@t2t2 t2t2 commented Oct 23, 2018

When using rollup with uglify the resulting code may have lines longer than 32767 (Int16) characters, which when decoded can cause int overflow and negative columns due to #74 & #75 changes

image

@Rich-Harris
Copy link
Owner

thank you! released 1.4.4

mislav added a commit to github/rollup.js that referenced this pull request Nov 27, 2018
Sourcemaps were broken for lines longer than 32767 characters, which can
happen if a large bundle was generated and minifed using Rollup.

Rich-Harris/sourcemap-codec#77

Regressed in v0.66.3 8a8721e
lukastaegert pushed a commit to rollup/rollup that referenced this pull request Dec 3, 2018
Sourcemaps were broken for lines longer than 32767 characters, which can
happen if a large bundle was generated and minifed using Rollup.

Rich-Harris/sourcemap-codec#77

Regressed in v0.66.3 8a8721e
@GrosSacASac
Copy link

What happens with lines longer than 4294967296 ? (int 32)

lukastaegert pushed a commit to rollup/rollup that referenced this pull request Dec 7, 2018
Sourcemaps were broken for lines longer than 32767 characters, which can
happen if a large bundle was generated and minifed using Rollup.

Rich-Harris/sourcemap-codec#77

Regressed in v0.66.3 8a8721e
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants