New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ArraySeq is boxing on map. #79
Comments
So I'm looking for some level of unification of immutable compile time Array wrappers and ProductVals. ProductVals should at some point be generalised to compound Value types. All of the Array based types should have both an immutable Array based wrapper and an extensible ArrayBuffer based type. These will all be based on an implicit builder. I'm not sure if the user methods such as map, mapBuff, flatMap, flatMapBuff, iMap etc should be implemented in the calling class or in the Builder. So each type will have:
If we have a Class Ma and we want to map it to Nb
The method should definitely not be implemented on the Nb class. Nor should the setElem methods be on the Ma class or Nb, only on the Builder. |
@w0d Could you look at Util//test/src/ostrat/ArrTest.scala. I want to get user's perspective on the functionality, and the naming. Does it look straightforward and comprehensible. I've still got to implement the ArrBase interface for ProductVals but I think it should be fairly straightforward. |
That last commit had the wrong message. Should say ProductVals now extends ImutArr |
not too bad for me - could work most of it out and the rest from assuming the tests are true (negating the need to grab the scala reference book) |
@w0d Hopefully naming is clearer now. |
ArraySeq is currently aliased as Arr. See Discourse and Scala-issues
The text was updated successfully, but these errors were encountered: