FINAL CAPSTONE

[samlorlah]

This project is the final capstone for the Microverse program. Below is the milestone covered during this project:

Backend (Rails)

• Setup Rails App
• Setup authentication (Devise & Devise JWT)
• Set up Models and Migrations
• Set up API controllers and Routes
• Setup Serializers
• Setup Integration and module tests
• Setup API documentation

---

Frontend (ReactJs)

• Install ReactJs
• Install all dependencies (Redux toolkit, etc)
• Set up Pages
• Set up Components
• Setup Redux
• Setup Authorization
• Store JWT token and auth user in local storage
  Link to Front end : https://github.com/RichardChileya/booking-app-front-end

[mcrd25]

Hi Team,

Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!

Highlights

• good job with overall requirements 👍
• Good job adding tests for Back-End (Consider adding for Front-End as well)👍

Required Changes ♻️

Check the comments under the review.

• Address comments not marked as [OPTIONAL]
• Try to remove commented out code you no longer need
• Try to solve the issue with your swagger. I see this when I visit the doc url:
  
• Finish missing tests
• Add reference to Front-End in to make it easier to review
• [FRONT-END] Consider moving forward that the application needs to look exactly like design with exception of photos, titles and descriptions

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

You can also consider:

[OPTIONAL]
Should always have positive and negative tests to ensure it works the way you expect it. Eg. What do you expect the output to be when it's not valid or when valid etc.
Consider making all your tests more extensive, not just this one. For this simple application, it may not catch a possible crippling bug, but in bigger applications, it definitely can. Consider this for all projects moving forward.

• Add Tests to front-end
• Are the square brackets around some list items and headings intentional? If not, you should definitely try to correct that
• there are Cases in Front-End code where your Componenets could be simplified with arrays and loops or resuable components
• If there is anything additional that aws not mentioned that you may need help with, please feel free to reach out to me on slack. My email is also on my github profile

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

---

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

[RichardChileya]

###: Changes implemented

• The Swagger endpoint has been added to the right path.
• all optional suggestions have been noted and we will be fixed
• Commented Code has been removed
• Front end link has been added to the pull request