Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Worker graceful shutdown #543

Merged
merged 2 commits into from May 11, 2020

Conversation

shivanshgaur
Copy link
Contributor

Using WaitGroup to prevent the exit of broker consumption goroutine when Unix signal is being handled

@codecov
Copy link

codecov bot commented May 10, 2020

Codecov Report

Merging #543 into master will decrease coverage by 0.09%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #543      +/-   ##
==========================================
- Coverage   38.01%   37.92%   -0.10%     
==========================================
  Files          32       32              
  Lines        3322     3330       +8     
==========================================
  Hits         1263     1263              
- Misses       1920     1928       +8     
  Partials      139      139              
Impacted Files Coverage Δ
v1/worker.go 3.39% <0.00%> (-0.07%) ⬇️
v2/worker.go 1.99% <0.00%> (-0.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40440de...860fe3b. Read the comment docs.

@RichardKnop RichardKnop merged commit 5d814a4 into RichardKnop:master May 11, 2020
@shivanshgaur shivanshgaur deleted the worker_graceful_shutdown branch June 12, 2020 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants