Added maintainers to spec #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
victorb
reviewed
Oct 19, 2016
| - List maintainer(s) for a repository, along with one way of contacting them (e.g. GitHub link or email). | ||
|
|
||
| **Suggestions:** | ||
| - This should be a small list of people in charge of the repo. This should not be everyone with access rights, such as an entire organization, but the people who should be pinged and who are in charge of merging PRs and so on. |
There was a problem hiding this comment.
Feels like it's missing a definition of "in charge". Currently it only mentions that it's people who are "in charge of merging PRs"
|
|
||
| **Suggestions:** | ||
| - This should be a small list of people in charge of the repo. This should not be everyone with access rights, such as an entire organization, but the people who should be pinged and who are in charge of merging PRs and so on. | ||
| - A subsection for contributors is also welcome here, but can go in the contribute section, too. |
There was a problem hiding this comment.
Since we're trying to build a standard for readmes, it would be better I think if we only have one way of doing things instead.
RichardLitt
force-pushed
the
feat/add-maintainers
branch
from
bc0c4ff
to
8f9adba
Compare
|
@victorbjelkholm Do you get notifications if I force push? Curious. |
|
@RichardLitt no, don't think so. Just get notifications regarding the mentions. I do think this looks good now 👍 |
|
Ok, will remember to ping. @martinheidegger, thoughts? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #30