Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests under git-2.2 #149

Merged
merged 1 commit into from Nov 29, 2015
Merged

Fix tests under git-2.2 #149

merged 1 commit into from Nov 29, 2015

Conversation

dottedmag
Copy link
Contributor

I have noticed that one of the tests failed under git-2.2

'branches' directory was obsolete and finally removed in recent git
versions.
@RichiH
Copy link
Owner

RichiH commented Apr 13, 2015

Could you try to make this dependent on version? I.e. with legacy Git, test for it, with 2.2 you don't?

@dottedmag
Copy link
Contributor Author

It's been deprecated since 2008, maybe it's easier to just drop it? git/git@1dd1239

@jwhitley
Copy link
Contributor

+1 on accepting this PR as-is.

I'm on git 2.4.5, and just got hit by this while trying to install and test the feature/foreach branch.

vcsh (rightly) doesn't directly depend on the actual presence or absence of this directory, only on git's external behavior. The whole t/100-init.t suite only has meaning as a collective because each test is fingerprinting the implementation details of git's repo structure. Moreover, I can't imagine a case where vcsh init causes an (old, < v2.2) version of git to pass this suite except for ok -d 'branches';.

RichiH added a commit that referenced this pull request Nov 29, 2015
@RichiH RichiH merged commit 59c4a2d into RichiH:master Nov 29, 2015
@RichiH
Copy link
Owner

RichiH commented Nov 29, 2015

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants