Strikethrough by design or issue?

[iisfaq]

I am not sure if this is a bug or by design.

~~
line 1
line 2
~~

But if I select two lines and I want to strike through them both the strike though is not rendered in the preview (this may be by design since it does not render here either (see above). Also renders above as two lines, but the preview in MM is 1 line.

~~
Run the file
docker run --name linuxdockeridlcompiler -it linuxdockeridlcompiler:Dockerfile
~~

Rendered as

A strike-through on a single line or part of a line works fine.

~~Run the file~~

Maybe if this is by design, you could add the strikethrough to each line in the selected area automatically?

~~line 1~~
~~line 2~~

line 1
line 2

Version 2.8

[RickStrahl]

Strikethrough - along with bold, italic, underline, etc. - are all inline elements, so they don't work across lines. This is due to the way HTML handles those markup elements.

I do like the idea of automatically marking up multiple lines...

This would really apply to all inline elements...

[RickStrahl]

I sat down to implement this but just realized that doing multiline as suggested doesn't make any sense because logistically multiple lines that are single lines (without a line break character) are still treated as a single paragraph.

Here's what I mean:

Seems too confusing to figure out what works and what doesn't if selectively applying multiline options. What would that apply to?

[RickStrahl]

Ok so more experiments. I added support for multi-line inlines and I suppose it works, even though I suspect this will raise more questions than it answers.

Note that the markup doesn't create breaking lines, it only puts the inline markup on every line. It doesn't automagically (and shouldn't) turn the lines into breaking lines. But this works now. You can also do multiple lines that are seperated by a blank line (a para break) and that works correctly as well.

I think I can live with this... Perhaps one more thing might be an option to enable this? Editor.MultLlineInlineMarkup=true perhaps?

[iisfaq]

Wow I was happy with your initial comments on this, you do work fast.

Cheers

[RickStrahl]

Any comments if this addresses your concerns?

I guess the main issue I have is that making mutliple lines that are essentially a single paragraph marked up is sub-optimal but it's simple that catches both the scenario of true multi-paragraph and single parargraph markup at least functionally.

[RickStrahl]

Please take a look at v2.8.2+ which includes these changes.

[iisfaq]

I just checked a couple of mins ago after I saw your email and it said no updates. And now there it is. I like the change, it feels logical to me, thanks for implementing it.:-) Cheers Chris

…

On Thu, Feb 2, 2023 at 12:03 PM Rick Strahl ***@***.***> wrote: Please take a look at v2.8.2+ which includes these changes. — Reply to this email directly, view it on GitHub <#1003 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABMO4UXZB2F2EZFTGY2EDXTWVLTSNANCNFSM6AAAAAAUMX6E6I> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[iisfaq]

I spotted one thing - if you have a soft return embedded in the block to be formatted it gets lost.

Chris

[RickStrahl]

Yes found this one yesterday and fixed. You should now be able to format a block of text for soft returns and then mark up each line with the italic inside of the soft returns.