Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Issue #4

Closed
hakkurishian opened this issue Nov 12, 2018 · 1 comment
Closed

Build Issue #4

hakkurishian opened this issue Nov 12, 2018 · 1 comment

Comments

@hakkurishian
Copy link

hakkurishian commented Nov 12, 2018

Since the last Version the file feedback.service.d.ts causes build errors on angular CLI 6.

ERROR in node_modules/ng-feedback/lib/feedback.service.d.ts(3,30): error TS1005: ';' expected. node_modules/ng-feedback/lib/feedback.service.d.ts(3,96): error TS1005: '(' expected. node_modules/ng-feedback/lib/feedback.service.d.ts(4,5): error TS1128: Declaration or statement expected. node_modules/ng-feedback/lib/feedback.service.d.ts(5,87): error TS1005: '(' expected. node_modules/ng-feedback/lib/feedback.service.d.ts(6,27): error TS1005: ';' expected. node_modules/ng-feedback/lib/feedback.service.d.ts(6,33): error TS1109: Expression expected. node_modules/ng-feedback/lib/feedback.service.d.ts(7,5): error TS1128: Declaration or statement expected. node_modules/ng-feedback/lib/feedback.service.d.ts(8,21): error TS1005: ',' expected. node_modules/ng-feedback/lib/feedback.service.d.ts(8,27): error TS1005: ';' expected. node_modules/ng-feedback/lib/feedback.service.d.ts(8,33): error TS1109: Expression expected. node_modules/ng-feedback/lib/feedback.service.d.ts(9,25): error TS1005: ',' expected. node_modules/ng-feedback/lib/feedback.service.d.ts(9,31): error TS1005: ';' expected. node_modules/ng-feedback/lib/feedback.service.d.ts(9,37): error TS1109: Expression expected. node_modules/ng-feedback/lib/feedback.service.d.ts(10,21): error TS1005: ',' expected. node_modules/ng-feedback/lib/feedback.service.d.ts(10,27): error TS1005: ';' expected. node_modules/ng-feedback/lib/feedback.service.d.ts(11,1): error TS1128: Declaration or statement expected.

Proposed Solution

I got it working after replacing the Rxjs related imports by

import {Observable} from "rxjs/Rx";

this is what my working file looks like:

`import {Observable} from "rxjs/Rx";

export declare class FeedbackService {
private screenshotCanvasSource;
screenshotCanvas$:Observable;
private feedbackSource;
feedback$: Observable<{}>;
initScreenshotCanvas(): void;
private generateExistingCanvas;
setCanvas(canvas: any): void;
setFeedback(feedback: any): void;
getImgEle(canvas: any): HTMLImageElement;
}
`

@RickonChen
Copy link
Owner

Hi @hakkurishian , it do work! Actually I had to manually to update the feedback.service.d.ts each time after building. I have updated code and published new viersion to npm. Thanks for providing the solution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants