Add schema title property to ClassTemplateModelBase #1320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does it have to be virtual? |
|
You're right - it's not absolutely necessary. I committed another change making it non-virtual. (I just made it virtual to provide the ability to override it in derived classes if needed) |
|
@RicoSuter I don't know why the tests have failed after this very simple change (making prop virtual -> non-virtual) - maybe an one-time error in Azure DevOps? Maybe it's possible for you to manually reschedule a check-run? Thank you very much in advance! |
|
Was a problem with benchmarks (slow DevOps). All fine. Thanks for the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a property "SchemaTitle" to ClassTemplateModelBase. The reason is that the "ClassName" is not the original one from the swagger file any more (at least the first character is always capitalized). We need the original unchanged title from the Swagger file in the class.liquid file so that we can add a custom attribute with it to the resulting code file on generation.