TS injection and baseUrl fixes #2204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Allows ConfigurationClass to be injected. * Handles empty baseUrl
RicoSuter
reviewed
Jun 4, 2019
| @@ -22,7 +22,7 @@ | |||
| {% endif -%} | |||
| this.http = http ? http : <any>window; | |||
| {% if UseGetBaseUrlMethod -%} | |||
| this.baseUrl = baseUrl ? baseUrl : this.getBaseUrl("{{ BaseUrl }}"); | |||
| this.baseUrl = baseUrl && baseUrl != "" ? baseUrl : this.getBaseUrl("{{ BaseUrl }}"); | |||
|
Thanks for the PR. Is the PR ready now? |
|
Happy to help. PR seems ready. I'm using the code here and it works great. |
RicoSuter
reviewed
Jun 6, 2019
src/NSwag.CodeGeneration.TypeScript/Templates/FetchClient.liquid
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows ConfigurationClass to be injected.
If a configuration class is specified, it has to be added to the
injectlist. Otherwise, Aurelia's DI will pass an empty string for the configuration class instance. For that matter, I'm really not sure how/why you'd want to inject a string with DI.Handles empty baseUrl
The string that is injected into the client is always empty... so the check I added here allows the base class to configure the base URL.